search

koreader / koreader-base

Base framework offering a Lua scriptable environment for creating document readers
http://koreader.rocks/
GNU Affero General Public License v3.0
136 stars 106 forks source link

Lua blitter: Fix the mul method for grayscale Color data types #1922

Closed NiLuJe closed 2 months ago

NiLuJe commented 2 months ago

We want to access the actual luminance value instead of the struct pointer ;o).

Fix https://github.com/koreader/koreader/issues/12473

This change is Reviewable

NiLuJe commented 2 months ago

At a quick re-re-review, I don't appear to have bungled this up anywhere else ;).

Not quite sure how I missed it in the first place, as I did test the Lua blitter back in January, on both color & grayscale BBs.

┌─(niluje@ahsoka:pts/14)────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────(/var/tmp/niluje/koreader)─┐
└─(0.79:19%:16:44:%)── h 1 | rg EMULATE_BB_TYPE                                                                                                                                                                                                                                                                                                        ──(Sat, Sep 07)─┘
 2378  23.1.2024 13:17  0:00  env EMULATE_BW_SCREEN=1 EMULATE_BB_TYPE="BB8" ./kodev run
10086  7.9.2024 16:40  0:30  env EMULATE_BW_SCREEN=1 EMULATE_BB_TYPE="BB8" ./kodev run

Must have implemented the MUL stuff later or something... -_-".