search

koreader / koreader-base

Base framework offering a Lua scriptable environment for creating document readers
http://koreader.rocks/
GNU Affero General Public License v3.0
136 stars 106 forks source link

luajit: patch out library from pkg-config entry when not used #1930

Closed benoit-pierre closed 1 month ago

benoit-pierre commented 1 month ago

To prevent Lua modules from linking with it.

This change is Reviewable

benoit-pierre commented 1 month ago

In preparation for using pkg-config to handle LuaJIT's compilation flags in some external projects (luajit.pc is currently not used).

NiLuJe commented 1 month ago

Wasn't there a thing where on Android (and possibly macOS?), Lua/C modules needed to be explicitly linked to the luajit lib for... reasons?

benoit-pierre commented 1 month ago

Yes, which is why it's only patched out when we don't use the luajit library.

NiLuJe commented 1 month ago

Oh, duh'. Long day, sorry ;).