koreader / koreader

An ebook reader application supporting PDF, DjVu, EPUB, FB2 and many more formats, running on Cervantes, Kindle, Kobo, PocketBook and Android devices
http://koreader.rocks/
GNU Affero General Public License v3.0
16.99k stars 1.27k forks source link

FR: option for double-page layout in muPDF #10204

Closed mergen3107 closed 11 months ago

mergen3107 commented 1 year ago

Does your feature request involve difficulty completing a task? Please describe. I would like to have an option to show two pages at once in landscape mode in muPDF.

Describe the solution you'd like Similar to crengine's two columns option.

Describe alternatives you've considered For now I am using Page Browser with one row and two columns. However I use it a lot in crengine as well where I set 9 pages overview, and I need to change the layout each time I switch between the file types by swiping (it takes a while).

Additional context So in this double-pages mode I am not able to actually read text on 7,8-inch screen, of course, but it gives a good overview for repetitive plots. Page Browser has a lot of extra things around the pages, so it makes it harder to read. In the long term I plan to get a larger screen eReader, so this feature will be awesome to have.

mergen3107 commented 1 year ago

@poire-z

With Kindle Scribe also being able to have KOReader now, does this FR have a chance to have attention? :D

NiLuJe commented 1 year ago

Probably not, our PDF backend is pain ;).

poire-z commented 1 year ago

Don't ask me, I'm not familiar with the PDF/Kopt/ReaderPaging stuff. (I guess if MuPDF/Kopt do not do it themselves, it would need us to combine 2 output, and adjust all x/y... so probably some quite heavy work.)

mergen3107 commented 1 year ago

Alright, I will resort to Page Browser then :D

Thank you guys!

gingerbeardman commented 1 year ago

Came here to request this :(

mergen3107 commented 1 year ago

@gingerbeardman We can ask upstream mupdf, I am just not sure they are willing to implement new features :D

gingerbeardman commented 1 year ago

I'll try.

Also I'm reading above: what is crengine? Can I use that? Edit: I now see that crengine is for epub, mupdf is for pdf

So it's clear my goal is to read magazines with two page spread.

Frenzie commented 1 year ago

We can ask upstream mupdf, I am just not sure they are willing to implement new features :D

I think they'd just say downstream should render two pages themselves. But you can always ask I suppose. :-P

gingerbeardman commented 1 year ago

insert jpg of two Spiderman pointing at each other

mergen3107 commented 1 year ago

Let's reopen this issue since it gets more attention :D

gingerbeardman commented 1 year ago

I just read that apparently mupdf already supports it

core.setDisplayPages(2);

https://github.com/joniks/Android-MuPDF/blob/6d544a72e82ee89a48db965c7fa07f4c1b71274a/library/src/com/artifex/mupdflib/MuPDFActivity.java#L504

benoit-pierre commented 1 year ago

That's their Android App, not the core MuPDF library.

gingerbeardman commented 1 year ago

That's their Android App, not the core MuPDF library.

Interesting! I have tried their android app and it doesn't show two pages in Landscape.

gingerbeardman commented 1 year ago

I registered for MuPDF bug tracker and it's a WONTFIX for them to implement it

(in their own app? in the library?)

https://bugs.ghostscript.com/show_bug.cgi?id=702484

Frenzie commented 1 year ago

We can ask upstream mupdf, I am just not sure they are willing to implement new features :D

I think they'd just say downstream should render two pages themselves. But you can always ask I suppose. :-P

But more seriously, then it also wouldn't work in DjVu or picture documents (like GIF or TIFF), so it makes a lot more sense to do it somewhere around here regardless.