Icon change request

[Billymaysere]

I don't change bottom menu settings often but whenever I do I see the symbol discussed here and have to look up what's going on because the symbol looks like it's some sort of unsuccessful rendering. I think changing it to a rectangle of the document with a question mark in it or something like that would make it more clear.

[poire-z]

because the symbol looks like it's some sort of unsuccessful rendering

Good, at least you guessed right it is about "rendering" :) The animations (the following icons) should somehow allow you to guess the unsuccessful is becoming successful, and that all ends well in the end. I'm not sure a document with a question mark would make it clearer (and that it's about "rendering"). Can't think of any other or something.

[Billymaysere]

Good, at least you guessed right it is about "rendering" :)

Except I thought the icon was broken not that it was trying to say the document was broken. In my opinion it looks like if your eink screen didn't refresh right between two images trying to be displayed. As far as more alternate design suggestions, I don't know what kind of frame rate you can get on the animations, but something like a 2 or 3 frame loading wheel document, or a document with lines of 'text' going from 1px thick to 2px so it's not just sitting with a broken looking icon in the corner.

[poire-z]

Oh, you meant the icon rendering/painting/refreshing was broken :) Good, at least you guessed right it is about "something being broken" :) And it eventually auto gets unbroken with shiny rays and a reload icon.

I don't know what kind of frame rate you can get on the animations, but something like a 2 or 3 frame loading

The animation is not a real controlled/movie animation: the change of icon happens at every next step towards getting unbroken. Still no better idea for an icon, and given that we got this somehow consistent serie of 4 icons from broken to unbroken, that most of us were quite happy with, and you are the first to complain about it (the icons, not the presence of such icons, which other people did complain about), it probably won't change until you are legion :)

[Frenzie]

I think an earlier proposal may have been based on the typical refresh icon but that also had issues.

[Commodore64user]

what is this (poke ball, I guess) one?

I sometimes see it on ePubs but have no idea what it means. gotta catch 'em all?

[poire-z]

See #11514. #11327. https://github.com/koreader/koreader/issues/11223#issuecomment-1872979980

[offset-torque]

Ok, I will add an "Icons/Indicators of KOReader" to the user interface section of the user guide, at least for easy referencing in questions like this. We have a partial rendering section which answers this specific question but you have to know what you are searching for to find it.

[offset-torque]

@Billymaysere

You can search for Partial rendering support in our user guide to see which stages of rendering those icons correspond to.

[Commodore64user]

what is this (poke ball, I guess) one?

I sometimes see it on ePubs but have no idea what it means. gotta catch 'em all?

This poke-ball went from cute and quaint to annoying in such a short time. Every time one triggers content selection on non-touch that "thing" (replace 'thing' with your favourite expletive) appears. Any chance we could do something about it?

[Frenzie]

That sounds like a bug, but I think there's an actual issue about the pokeball sticking around in edge cases somewhere.

[poire-z]

This poke-ball went from cute and quaint to annoying in such a short time. Every time one triggers content selection on non-touch that "thing" (replace 'thing' with your favourite expletive) appears.

I suggest we solve the problem by just disabling content selection on non-touch - or close your PR, as you must be the only one using it, and obviously, the user experience is not good :)

Any chance we could do something about it?

It should trigger on very-long-press. You could see what delay you have somewhere in the top menu, and if it's because the way you trigger content selection, which somehow generate a long-press (if that's how you emulate it) generate such a long delay, or may be you miss some events. Or may be it's ReaderHighlight and its _resetHoldTimer() and related code that need some help to better support your new way of doing content selection.

I think there's an actual issue about the pokeball sticking around in edge cases somewhere.

https://github.com/koreader/koreader/issues/11223#issuecomment-2104713286

[Commodore64user]

I suggest we solve the problem by just disabling content selection on non-touch - or close your PR, as you must be the only one using it, and obviously, the user experience is not good :)

Very funny. Joke aside, that predates me, it's just that making CS easily accessible has just exacerbated it.

It should trigger on very-long-press. You could see what delay you have somewhere in the top menu, and if it's because the way you trigger content selection, which somehow generate a long-press (if that's how you emulate it) generate such a long delay, or may be you miss some events.

Well that's the problem, i can't as those settings are locked behind a hasTouchScreen gate

Or may be it's ReaderHighlight and its _resetHoldTimer() and related code that need some help to better support your new way of doing content selection.

Just for clarification, i am not changing how CS works. My changes are simply making it much (much) easier to access it and making it user adjustable.

Could we maybe just not trigger the poke thing on non-touch? I mean there is no touch there after all. ;)

[poire-z]

You can try adding into that function that is called (only on Non-Touch?):

 function ReaderHighlight:onStartHighlightIndicator()
+    -- disable that long-press icon, as, as NT devices owners, we are slow people, and we are slow at selecting text
+    self.long_hold_reached_action = function() end
     if self.view.visible_area and not self._current_indicator_pos then

so as soon as this function is called, it overrides and disable the one we use to trigger the display of the icon.

[Commodore64user]

yes that is nt exclusive.

wow, you just insulted a total of five people, way to go poire