search

korfuri / WhatTheRack

WhatTheRack randomizes your VCV Rack so you make new discoveries
Do What The F*ck You Want To Public License
37 stars 2 forks source link

Randomness not so random. #2

Closed NoxyNixie closed 5 years ago

NoxyNixie commented 5 years ago

I love the idea of loosing some control while choosing your modules ... however I don't want to fill my rack with bunches of modules each time so I'm mostly interested in the "What The Mod" module.

Unfortunately after testing for just a very short period I found out that it is not random at all.

The following steps will show exactly what I mean:

It seems that the lists are randomized the same way each time instead of being seeded with a more random seed like the current time.

korfuri commented 5 years ago

Interesting, I use the system's default randomness pool. What OS are you running?

On Sun, May 12, 2019 at 9:25 PM Mark Sanders notifications@github.com wrote:

I love the idea of loosing some control while choosing your modules ... however I don't want to fill my rack with bunches of modules each time so I'm mostly interested in the "What The Mod" module.

Unfortunately after testing for just a very short period I found out that it is not random at all.

The following steps will show exactly what I mean:

  • Start new instance of VCV Rack
  • Add "What The Mod"
  • Click 5 times on "VCO"
  • Note the modules you get and in what order.
  • Reset your rack and relaunch VCV Rack
  • Add "What The Mod"
  • Click 5 times on "VCO"
  • Notice exactly the same modules in the same order.

It seems that the lists are not randomized at all when initialized (or even when I choose to randomize "What The Mod").

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/korfuri/WhatTheRack/issues/2, or mute the thread https://github.com/notifications/unsubscribe-auth/AAISPJ2TAHDIP4OWOBDBZTTPVAECPANCNFSM4HMKH7RA .

-- Uriel Corfa

NoxyNixie commented 5 years ago

Windows 7.

I know on some systems the random pool is not randomly seeded by default and looking at your code I didn't quickly see any seeding happening which would suggest it would use some form of deterministic randomization which does explain why the same modules pop up each time.

NoxyNixie commented 5 years ago

Thanks for the fix. When I wanted to try this out I went to your releases page here on github and downloaded the WhatTheRack-0.6.2-win.zip file. This build (or at least what is in that zip) seems to not fix the issue.

However I do notice the 0.6.2 in that filename and now suspect the build process uploaded the wrong files perhaps?

korfuri commented 5 years ago

Yeah, I messed up the versioning. Try again with the files at https://github.com/korfuri/WhatTheRack/releases/tag/0.6.3 and let me know.

On Mon, May 13, 2019 at 6:45 PM Mark Sanders notifications@github.com wrote:

Thanks for the fix. When I wanted to try this out I went to your releases page here on github and downloaded the WhatTheRack-0.6.2-win.zip file. This build (or at least what is in that zip) seems to not fix the issue.

However I do notice the 0.6.2 in that filename and now suspect the build process uploaded the wrong files perhaps?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/korfuri/WhatTheRack/issues/2#issuecomment-491753518, or mute the thread https://github.com/notifications/unsubscribe-auth/AAISPJ5ENOFU2Q7EABXQAQDPVE2CRANCNFSM4HMKH7RA .

-- Uriel Corfa

NoxyNixie commented 5 years ago

Yep looks like its random now. Thanks a bunch ;)