search

korfuri / WhatTheRack

WhatTheRack randomizes your VCV Rack so you make new discoveries
Do What The F*ck You Want To Public License
37 stars 2 forks source link

updated WhatTheRack to V2 #7

Closed alefnull closed 2 years ago

alefnull commented 2 years ago

please forgive me if i've done any of this wrong, as this is my first actual pull request.

i've done my best to update your plugin to build and run against Rack V2, and it seems to work fine so far. i'm fairly new to c++ and specifically Rack development, so i'm not 100% sure it's completely stable or foolproof or even efficiently done or anything.

if anything needs to be changed or fixed i'll gladly do so.

korfuri commented 2 years ago

The change looks good to me. I don't have a setup to verify it with Rack 2 and I have not used Rack 2 so I'm a bit reluctant to merge it as such. Would you be interested in adopting the module, so you can make the decisions yourself?

alefnull commented 2 years ago

i'd be interested, but i must admit this is all quite new to me, as i mentioned, so i'm unsure what would be required.