Issues with float_math.h

korginc / logue-sdk

This repository contains all the files and tools needed to build custom oscillators and effects for the prologue synthesizer.

BSD 3-Clause "New" or "Revised" License

818 stars 304 forks source link

Closed musicalentropy closed 4 years ago

musicalentropy commented 4 years ago

In float_math.h, I have seen a few issues:

some typos with "ampltitude" which should be replaced with "amplitude"
in the function fastlogf and fasterlogf, the constant "0.69314718f" should be replaced with the macro MN_LN2
the function "fasterampdbf" might be even faster if the factor is precalculated instead of being 20.f/fasterlog2f(10)
the function "fasterdbampf" is wrong, it should be "fasterpowf(10.f, 0.05fdb)" instead of "20.ffasterpowf(10.f, 0.05f*db)"

etienne-korg commented 4 years ago

Thanks for pointing this out. Fixed in ab654af0e29e5eb6eab7289d05699b45417d1f68

musicalentropy commented 4 years ago

Thanks! And don't forget the "/** dB to ampltitude" typos, like for example in line 796 ;)