search

korginc / logue-sdk

This repository contains all the files and tools needed to build custom oscillators and effects for the prologue synthesizer.
BSD 3-Clause "New" or "Revised" License
818 stars 304 forks source link

fastpow2f bug #54

Open dukesrg opened 3 years ago

dukesrg commented 3 years ago

https://github.com/korginc/logue-sdk/blob/ab654af0e29e5eb6eab7289d05699b45417d1f68/platform/prologue/inc/utils/float_math.h#L680

Current fastpow2f suffer from the lost of precision. depending on the input value it could be times worse then with faster2f

offset must be applied like in the original verion https://github.com/pmineiro/fastapprox/blob/master/fastapprox/src/fastexp.h#L54

dukesrg commented 1 year ago

@etienne-korg Please refer to this commit in my fork as current fastpow2f is imprecise https://github.com/dukesrg/logue-sdk/commit/8874c04e0f030d51378cff00a4061797d8a5b461