korginc / volcasample

volca sample SDK - a sample and sequence encoding library for volca sample.

BSD 3-Clause "New" or "Revised" License

351 stars 37 forks source link

Closed avtobiff closed 9 years ago

avtobiff commented 9 years ago

Please version and tag releases, semantic versioning is widely used.

In #3 the soname has a hardcoded placeholder version of 1.0.0, this should be generated from a release version.

Hideki-Fujii commented 9 years ago

Thank you pointed out. We are going to be addressed in a few days.

avtobiff commented 9 years ago

Great!

I want to package this for Debian and need a soname.

avtobiff commented 9 years ago

5 assumes that tags are named `x.y.z` (or `x.y`) where x, y are digits.

Hideki-Fujii commented 9 years ago

I've create a 'tag 1.0.0' to initial release. And　we've check the operation of the #5.

We will add APIs to get version. Then, I will create a new tag.

avtobiff commented 9 years ago

On Tue, Dec 9, 2014 at 8:00 AM, Hideki-Fujii notifications@github.com wrote:

I've create a 'tag 1.0.0' to initial release. And　we've check the operation of the #5.

Great!

I verified that it works locally myself before sending a pull request of course.

We will add APIs to get version.

I don't understand what you mean...

Then, I will create a new tag.

Now when you have created a tag you need to stick by it.