Generics and reworks to prepare for testing in python (with scipy as reference)

korken89 / biquad-rs

A Rust library for digital second order IIR filtrers, also known as biquads

Apache License 2.0

49 stars 13 forks source link

Generics and reworks to prepare for testing in python (with scipy as reference) #13

Closed boscs closed 10 months ago

boscs commented 1 year ago

Hey,

Thank you for your work and what you gave to the comunity. I tried to use you're crate in an embeded context but face a bug that I can't yet explain in my code.

I'm going to test in python against scipy to check for inconsistencies. So I first aplied generics to limit code surface.

boscs commented 12 months ago

I added a factory method to respond to #12 I think it's ready to be merged now

boscs commented 12 months ago

BTW thresholds of accepted error are not homogenous but I couldn't find a way to make the filter more in linewith scipy's. I suspect bandpass filter are just less stable.

boscs commented 11 months ago

Hey @korken89, Sorry to at you directly, would you have 5 minutes to look at the pull request and indicate me if there's anything you'd like me me to fix before it can be merged? Thanks in advance,