search

korken89 / fugit

`fugit` provides a comprehensive library of `Duration` and `Instant` for the handling of time in embedded systems, doing all it can at compile time.
Apache License 2.0
55 stars 16 forks source link

mirror From methods #40

Closed burrbull closed 1 year ago

korken89 commented 1 year ago

Hi @burrbull , thanks for the PR!! Sorry this has gone under my radar.

Could you write a small motivation to this change? I'm not quite following what it is fixing other than adding more shorthands.

Thanks!

burrbull commented 1 year ago

This just makes code slightly clearer and similar to From / Into way. It is strange to have into but don't have from and vise versa.

korken89 commented 1 year ago

Alright, looks good! :+1:

Could you expand the tests with the new APIs?

burrbull commented 1 year ago

Alright, looks good! +1

Could you expand the tests with the new APIs?

I've added several. Writing docs and tests make me cry.

korken89 commented 1 year ago

I'll fix adding more tests in the API test!