korken89 / smlang-rs

A State Machine Language DSL procedual macro for Rust
Apache License 2.0
192 stars 28 forks source link

fix warnings and clippy nit #70

Closed mhammerly closed 3 months ago

mhammerly commented 3 months ago

~because these tests failed on master i ignored them in #68 but it turns out the failure was just due to the error messages we were expecting having an extra newline. tests all pass, examples all build~

test failures were nightly-only so i reverted them, leaving the warnings and clippy nit

also cleaned up some warnings and clippy's one nit

doesn't seem worth mentioning in CHANGELOG.md but i can if we want that CI check to pass

mhammerly commented 3 months ago

oh hm. it looks like stable wants the extra newline but nightly (which i run locally) doesn't

i can revert the test changes if you want the warnings/clippy fix now, else i guess we can close this and reopen if/when the new error format makes it to stable

sorry for the noise!