Fallible actions support

korken89 / smlang-rs

A State Machine Language DSL procedual macro for Rust

Apache License 2.0

193 stars 28 forks source link

Fallible actions support #73

Closed dkumsh closed 1 month ago

dkumsh commented 1 month ago

As discussed at https://github.com/korken89/smlang-rs/issues/44

Fixes #44

This PR has 3 commits:

add fallible actions support
disallow guards mutating context/state (&mut self -> &self)
rename GuardError to TypeError as it is now used not only by the guards, but also by the actions

ryan-summers commented 1 month ago

@dkumsh I'm refactoring internal state management in https://github.com/korken89/smlang-rs/pull/76 to prevent the "State is None problem, which will simplify this a lot. If you want to wait until that PR gets merged and then rebase/merge, that would probably be easiest.

dkumsh commented 1 month ago

@dkumsh I'm refactoring internal state management in #76 to prevent the "State is None problem, which will simplify this a lot. If you want to wait until that PR gets merged and then rebase/merge, that would probably be easiest.

Thanks, totally makes sense. Will wait. Please let me know.

ryan-summers commented 1 month ago

Alright, #75 is now merged, so feel free to integrate that into your PR :)

ryan-summers commented 1 month ago

@dkumsh Did you intentionally close this PR? I think the changes would still be nice :)

dkumsh commented 1 month ago

@ryan-summers I think I closed it unintentionally.

I am re-opening this PR after rebasing on master.

As we agreed on the guards, I keep the change as well.