korma / Korma

Tasty SQL for Clojure.
http://sqlkorma.com
1.47k stars 222 forks source link

Added support for Vertica JDBC driver #214

Closed cbenning closed 10 years ago

cbenning commented 10 years ago

I added support for HP Vertica. I've tested it with our local DB and Vertica JDBC driver 7.0.1 and it works fine.

bitemyapp commented 10 years ago

@cbenning Would you add to the documentation that this is supported and what versions of the drive are likely to work? I'm prepared to go ahead and merge this once that is done if no objections are raised.

cbenning commented 10 years ago

@bitemyapp I've updated the docs using 'lein doc'. Please advise. Thanks.

bitemyapp commented 10 years ago

@cbenning now fix the build :)

cbenning commented 10 years ago

@bitemyapp Are you referring to it being 0.3.1-SNAPSHOT and it should be 0.3.0-RC6?

bitemyapp commented 10 years ago

@cbenning the red "X failed -- The Travis CI build failed" thingy in this thread. The build failed. Did you run lein test?

cbenning commented 10 years ago

@bitemyapp Missed a file to commit, my bad.

bitemyapp commented 10 years ago

@cbenning build is still failing.

cbenning commented 10 years ago

@bitemyapp Test passed.

bitemyapp commented 10 years ago

@cbenning can you squash the commit history now? I'd prefer unnecessarily broken commits not be spread across the history so test bisection is still practical.

cbenning commented 10 years ago

@bitemyapp Rebased, and tests passed.

bitemyapp commented 10 years ago

@cbenning thank you very much :)