search

korma / Korma

Tasty SQL for Clojure.
http://sqlkorma.com
1.47k stars 222 forks source link

Replace C3P0 with HikariCP (or add HikariCP support) #224

Closed brettwooldridge closed 8 years ago

brettwooldridge commented 10 years ago

Thought I'd post there here, as I was emailed (on behalf of HikariCP) asking about support for HikariCP in Korma. We're not Clojure programmers, but if there is anything the HikariCP team can do to help, let us know.

hlship commented 10 years ago

I think it would be good to break the connection between Korma and C3P0 and make that aspect pluggable, or simply the application's responsibility. C3P0 has some nasty features related to how it initializes ... it tends to spew a lot of meaningless errors at startup.

ttasterisco commented 10 years ago

:+1: for this

how hard will it be to put something between korma and connection pooling libraries?

drusellers commented 8 years ago

is this issue still open given the above PRs?

immoh commented 8 years ago

It has always been possible to use any datasource implementation by providing :datasource key in the db spec map. Korma uses c3p0 by default, and it hasn't been possible to exclude it from dependencies which was fixed by #309.

immoh commented 8 years ago

Starting from 0.4.3 it is possible to exclude c3p0 and use any connection pool library.