Closed DTB01 closed 9 years ago
Some things to fix before I can merge this:
add-joins
unnecessary?Thanks.
Will fix tests and docstring. The extra type arg to add-joins seem necessary. Unless i am completely missing something here.....
Thanks
Fixed docstring and added tests. Squashed and rebased.
Cheers
Thanks!
Currently, it is possible to specify a type (e.g. :inner) when doing a join with an explicit clause
When joining entities based on their relation as below, the type is defaulted to :left
And it is not possible specify a type, i.e. not possible to do
I've enabled this and made the change so that the arglists look like so
I believe this is very helpful as it allows us to join entities using an arbitrary join-type, without having to repeat the join constraints from the rels that we already defined in defentity.