search

korma / Korma

Tasty SQL for Clojure.
http://sqlkorma.com
1.48k stars 222 forks source link

Add initial-pool-size config to c3p0 configs #256

Closed AKurilin closed 9 years ago

AKurilin commented 9 years ago

Being able to configure the initial pool size in c3p0 is pretty convenient and I'd love to be able to expose that through Korma. For reference: http://www.mchange.com/projects/c3p0/#initialPoolSize

Please note that I have no idea how to run the UTs on this project, so let me know if there's a straightforward way of trying that out. I ran the full UT suite of our API using this custom version of Korma and had no trouble and was able to verify intended behavior.

bitemyapp commented 9 years ago

@AKurilin great work snagging the 2^8 issue on this project.

AKurilin commented 9 years ago

@bitemyapp That's pretty neat ;)

bitemyapp commented 9 years ago

@AKurilin I'm not actually here to make any decisions or do anything productive though, sorry. Somebody else (probably @immoh) will have to review your PR :)

immoh commented 9 years ago

Looks fine otherwise but please don't edit the docs manually. They can be regenerated with lein doc but this is not strictly necessary as I will anyway recreate them when publishing next release.

Tests can be run with lein test, or lein run-tests which runs tests using several different Clojure versions.

AKurilin commented 9 years ago

@immoh Makes sense, thanks for clarifying. Let me know if you need me to do anything else.

immoh commented 9 years ago

Please remove doc changes or regenerate all docs so that I can merge this.

AKurilin commented 9 years ago

Done, removed doc changes.

immoh commented 9 years ago

Thanks!