korma / Korma

Tasty SQL for Clojure.
http://sqlkorma.com
1.48k stars 222 forks source link

Fixes korma.sql.engine so it applies naming from current db-spec to fields #293

Closed ls4f closed 9 years ago

ls4f commented 9 years ago

No idea what I messed up yesterday, but this appears to be enough

immoh commented 9 years ago

Looks good otherwise but I think the exception in test should be checked in more detail (use more specific exception class and match the message using thrown-with-msg?.) It is too easy to introduce regression and not catch it by the test if we're only checking for java.util.Exception.

ls4f commented 9 years ago

Restyled it a bit while I'm at it - seems more "LISPy" that way