Fixes korma.core.get-db-keys and belongs-to so that when a fk option …

korma / Korma

Tasty SQL for Clojure.

http://sqlkorma.com

1.47k stars 222 forks source link

Closed k13gomez closed 9 years ago

k13gomez commented 9 years ago

…is defined a parent entity defined with a subselect table can be retrieved correctly; issue #300

immoh commented 9 years ago

This is fine but please remove the whitespace changes so that history is easier to follow.

k13gomez commented 9 years ago

Sorry, first time doing this, is there a simple way to remove the white-space changes or do I need to close this Pull Request and open a new one?

k13gomez commented 9 years ago

opening new pull request without whitespace changes.

immoh commented 9 years ago

It is enough to push to the same branch, the PR will get updated automatically.

Here's what I would have done:

git reset HEAD^ to remove the previous commit but keep the changes in the working directory
edit files so that whitespace changes are no longer present
commit
git push origin mybranch --force

k13gomez commented 9 years ago

thanks for the tips, I will keep it in mind for future contributions.