search

korma / Korma

Tasty SQL for Clojure.
http://sqlkorma.com
1.47k stars 222 forks source link

added support for hikari-cp, made it the default connection pool #307

Closed k13gomez closed 9 years ago

k13gomez commented 9 years ago

Also maintained c3p0 compatibility, connection pools area loaded dynamically. See #224 and @immoh 's comment on #127. This allows exclusion/inclusion of c3p0 or hikari-cp based on the user's needs, and the connection pool is resolved similarly to clj-http. Also, it opens Korma to extension via connection-pool multimethod.

immoh commented 9 years ago

Can you make a separate PR for allowing c3p0 exclusion, without Hikari stuff? We should still have c3p0 as dependency but enable users to exclude it and fallback to non-pooled mode.

I am not sure if I want to include code to configure all different connection pools in Korma but I'd definitely be interested in enabling users to use whatever they choose.

k13gomez commented 9 years ago

Sounds good, closing PR to open new PR for c3p0 exclusion only.