Do not generate SQL identifiers before query gets executed

korma / Korma

Tasty SQL for Clojure.

http://sqlkorma.com

1.48k stars 222 forks source link

Do not generate SQL identifiers before query gets executed #313

Open immoh opened 9 years ago

immoh commented 9 years ago

At least where condition column names and join column names are generated when the query is created. The database is not necessarily known at this point so it is possible that wrong delimiters are used, for example.

k13gomez commented 9 years ago

Let's discuss this one a bit, I've given it some thought, and here is a possible approach I've thought of:

Instead of generating SQL identifiers right away, represent them as a new type of special-map (let's say we call it ::identifier), and then use these special-maps to generate the identifiers (using bound-options) only when exec/->sql is invoked.

immoh commented 9 years ago

I think it sounds good, and can be easily refactored to something else later if needed. Another option would be to keep it as simple as possible and use keywords.

immoh commented 8 years ago

@k13gomez Any updates on this?

k13gomez commented 8 years ago

I've been short on time lately, started working on it but nothing concrete yet. I do like the idea of using special keywords as placeholders for the delimiters, etc.