Do not wrap subqueries of combined queries, fixes #328.

korma / Korma

Tasty SQL for Clojure.

http://sqlkorma.com

1.48k stars 222 forks source link

Do not wrap subqueries of combined queries, fixes #328. #329

Open juhovh opened 8 years ago

juhovh commented 8 years ago

More information in the related issue.

juhovh commented 8 years ago

Any comments or suggestions on how to improve this in case the proposed fix is not ok?

immoh commented 8 years ago

Apologies for not responding earlier.

I don't like duplicating code, and I don't like the fallback if we don't know that it is needed.

I suppose it is possible to have (raw "select * from foo") as a subquery, but I'm fine with supporting only subselect there. One possible solution would be to extract subselect handling without wrapping to a separate function and call that function from both map-val and sql-combination-query.