korma / Korma

Tasty SQL for Clojure.
http://sqlkorma.com
1.47k stars 222 forks source link

supprot predicate keyword #343

Closed zjhmale closed 8 years ago

zjhmale commented 8 years ago

i wonder if we can use both keyword and symbol to present predicates, this is really useful when we construct queries with predicate in a macro, make the code more readable.

zjhmale commented 8 years ago

@immoh @ibdknox @AlexBaranosky

immoh commented 8 years ago

This looks useful. Maybe the implementation could be simplified so that we have both symbols and keywords in one map and there wouldn't be need to check two maps?

zjhmale commented 8 years ago

ok, that sounds cool, let me fix it.

zjhmale commented 8 years ago

done @immoh

immoh commented 8 years ago

Please squash the commits into a single one and I'll merge this.

zjhmale commented 8 years ago

ok, just a minute.

zjhmale commented 8 years ago

done. @immoh

immoh commented 8 years ago

Thanks!

zjhmale commented 8 years ago

my pleasure :)