search

korma / Korma

Tasty SQL for Clojure.
http://sqlkorma.com
1.48k stars 222 forks source link

Korma is dependent on deprecated clojure.java.jdbc functionality #357

Closed venantius closed 7 years ago

venantius commented 8 years ago

Korma is now three major versions behind the latest clojure.java.jdbc version. This puts it at a place where it now relies on deprecated functionality - running the tests with the clojure.java.jdbc version pinned to even 0.5.8 generates tons of warnings around the usage of query, db-transaction*, db-do-prepared, and db-do-prepared-return-keys

There's been one PR to try to get things partway updated (#347), but I wanted to see if the maintainers would be open to a PR to get things even more updated than that (i.e. to 0.5.8 or even newer versions)

sthomp commented 8 years ago

👍 both Yesql and Hugsql are working on 0.5.8

immoh commented 7 years ago

I merged #358 instead.

venantius commented 7 years ago

Awesome, thanks!