korma / Korma

Tasty SQL for Clojure.
http://sqlkorma.com
1.48k stars 222 forks source link

[fix] Fix argslist metadata for join #359

Closed venantius closed 7 years ago

venantius commented 8 years ago

Although the current arglists metadata for korma.core/join is helpful to a human user, it's technically invalid for machines. Any compiler obeying the Clojure spec that attempts to parse the join macro will announce that a function cannot have two overloads with the same arity. We might benefit from expanding the documentation in this case to make up for the change.

immoh commented 7 years ago

Thanks!