korma / Korma

Tasty SQL for Clojure.
http://sqlkorma.com
1.48k stars 222 forks source link

#336: Update core/insert to more accurately reflect hash created by MSSQL #375

Closed rpazyaquian closed 7 years ago

rpazyaquian commented 7 years ago

Original Problem

The docstring for korma.core/insert implies that the hash returned by MSSQL is {:generated_key <ID>} instead of #336 's reported {:generated_keys <ID>}.

Proposed Solution

Update the docstring to explicitly state that MSSQL returns a hash of {:generated_keys <ID>}.

Endpoint

korma.core/insert docstring accurately describes MSSQL's hash structure.

Changes

rpazyaquian commented 7 years ago

This is my first contribution to the project. Please let me know if there is any particular process or guidelines I should follow.

immoh commented 7 years ago

Thank you!