search

korma / Korma

Tasty SQL for Clojure.
http://sqlkorma.com
1.48k stars 222 forks source link

New predicate support for where #376

Open sachinpkale opened 7 years ago

sachinpkale commented 7 years ago

Add support for not between and similar to predicates.

Add support for important C3P0 configs. Add convenient function for kylin DB. Add cloverage plugin for test profile.

AlexBaranosky commented 7 years ago

My 2 cents:

Make Korma easier to configure with the c3p0 --- and leave the c3p0 configuration to the user... don't attempt to wrap every c3p0 configuration, that's a waste of time/energy.

The way I configure my c3p0 pool at work is to just pull the pool off like (:datasource @(:pool db))

Then just call the java api on it like:

(.setCheckoutTimeout pool CONN_TIMEOUT)

AlexBaranosky commented 7 years ago

This code imho should be two PRs -- it's two different changes smooshed into one branch.

AlexBaranosky commented 7 years ago

Imho again: connection pool management by Korma is/was a mistake :) If there was ever going to be a Korma 1.0 -- I'd vote for removal of conn management from the api entirely. (Amen there probably should be by now, hehe -- nothing in the Clojure community ever makes it to 1.0.0 :) )