search

kornelski / cargo-deb

Make Debian packages directly from Rust/Cargo projects
https://lib.rs/cargo-deb
MIT License
408 stars 48 forks source link

look for triggers-file relative to manifest dir #38

Closed losynix closed 2 years ago

losynix commented 2 years ago

Hello, thank you for this useful crate !

Currently, when specifying a triggers-file that doesn't exist, cargo-deb will silently ignore it. The first commit of this PR adds a check and raise an error if the file can't be found. The second commit fixes the path of the file to be relative to the manifest directory, allowing triggers-file to be included when building outside of the manifest directory with the --package or --manifest-path options. I also fixed some clippy warnings.

kornelski commented 2 years ago

Thanks for the PR.

Including unrelated changes makes it harder to review the bug fix. Next time, please make PRs for one thing at a time.