search

kornelski / cargo-deb

Make Debian packages directly from Rust/Cargo projects
https://lib.rs/cargo-deb
MIT License
408 stars 48 forks source link

Missing maintainer scripts does not output logs #69

Open ltabis opened 1 year ago

ltabis commented 1 year ago

I add a bit of trouble lately creating debian packages using cargo deb: while I specified in my cargo manifest the maintainer-scripts field, none of my scripts where being picked-up by the program. In fact: the path I used was erroneous. Unfortunately, cargo deb did not provide any useful log/message about the matter.

Could it be interesting to display a warning when no files are found for maintainer scripts if the maintainer-scripts field is present in the cargo manifest ?

If you think it could be useful, I would be happy to make a pull request.

kornelski commented 1 year ago

Yes, it'd be useful. I think it could even fail the build if they're missing. But this may need to be checked after the build, so that build.rs has a chance to generate them.

ltabis commented 1 year ago

But this may need to be checked after the build

Alright, I will take a look then !

ximon18 commented 1 year ago

Related issue? https://github.com/kornelski/cargo-deb/issues/30

ltabis commented 1 year ago

Related issue? #30

More or less, this issue is related to eventual missing maintainer scripts, #30 is for missing assets. Emitting a warning for missing assets also seems like a good idea to me.