Closed ripytide closed 2 months ago
I've closed the other PRs for this one so I don't have to keep re-basing them :smile:
Gray.v for value is not terrible…
Luma.l
seems to have won the poll, but I dislike that a lot due to Luma
vs Luminosity
which may not have been an obvious discrepancy to a lot of people taking the poll.
I am just as happy with Gray.v
as I am with Gray.l
so if you prefer Gray.v
(and it just about came 2nd in the poll whereas no-one seems to like Gray.l
) then shall we go with Gray.v
as a final final final decision?
I can't wait to not ever have to think about naming consistency of pixel types ever again :laughing:
Do you have any other concerns other than the pixel naming on this PR? If not could we merge this one and change the Luma
naming in a future PR? I have some more changes (adding doc-tests, and various other minor tweaks) I'd like to make but don't want to add them to this PR in fear of making it too large and so making it harder to review.
Combination of PRs: #98, #99, #100 and this one.
98
99
100
--- failure trait_missing: pub trait removed or renamed ---
Description: A publicly-visible trait cannot be imported by its prior path. A
pub use
may have been removed, or the trait itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.32.0/src/lints/trait_missing.ronFailed in: trait rgb::ComponentSlice, previously in file /home/ripytide/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rgb-0.8.37/src/internal/pixel.rs:3 trait rgb::AsPixels, previously in file /home/ripytide/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rgb-0.8.37/src/internal/convert/mod.rs:15 trait rgb::ComponentBytes, previously in file /home/ripytide/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rgb-0.8.37/src/internal/pixel.rs:37 trait rgb::FromSlice, previously in file /home/ripytide/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rgb-0.8.37/src/internal/convert/mod.rs:69 trait rgb::ComponentMap, previously in file /home/ripytide/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rgb-0.8.37/src/internal/pixel.rs:70 trait rgb::ColorComponentMap, previously in file /home/ripytide/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rgb-0.8.37/src/internal/pixel.rs:79 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 0.925s] rgb