search

kornelski / rust-rgb

struct RGB for sharing pixels between crates
https://lib.rs/rgb
MIT License
98 stars 19 forks source link

fix semver-checks with lack of `alpha()` function #124

Closed ripytide closed 3 months ago

ripytide commented 4 months ago

Hmm, adding back the inherent alpha() method then causes conflict with the HasAlpha::alpha() trait method. Do we just use fully qualified syntax for calling it until the old legacy methods get removed when bump the major version?

kornelski commented 4 months ago

Is this meant for 0.8 or 0.9?

I assume fixing deprecation warnings on 0.8 is a prerequisite to upgrading to 0.9, so 0.9 won't need this method.

ripytide commented 4 months ago

Oh I didn't know that multiple branches were being maintained, I'd thought we had decided to release the new stuff as the 0.8 version in #113 so there's now only one branch with all the legacy things being deprecated?

kornelski commented 4 months ago

I've mistakenly assumed that Cargo would allow testing 0.8-alpha with 0.8 crates, but to my dismay it won't unify them.

This makes it hard to have public beta testing of the changes, and I'm afraid of just YOLOing everything from the 0.9 branch. So I've been releasing changes piecemeal on 0.8 where possible.

ripytide commented 4 months ago

We could do a sort of YOLO release but then quickly patch any issues that came up similarly to how #116 was handled? Not that many people update that regularly so if we were quick enough with the patches/testing we could probably get away with it?

We'd have to remove the legacy feature from the main branch first though.

ripytide commented 3 months ago

If we agree on the approach to release this branch on v0.8, would you like me to prune out the legacy feature?