search

kornelski / rust-rgb

struct RGB for sharing pixels between crates
https://lib.rs/rgb
MIT License
98 stars 19 forks source link

remove legacy feature #126

Closed ripytide closed 3 months ago

ripytide commented 3 months ago

Now this branch should be completely backwards compatible with the current v0.8 branch.

It would be nice if cargo had the ability to force all dependencies to use a custom version of a dependency which would let us test this manually on popular crates without making an actual release.

ripytide commented 3 months ago

Oh wait https://doc.rust-lang.org/cargo/reference/overriding-dependencies.html#working-with-an-unpublished-minor-version, it seems like cargo does indeed have such capabilities! We could do a bit of testing of popular reverse dependencies with this branch then. I'll start having a go.

ripytide commented 3 months ago

Now on this branch:

❯ cargo +stable semver-checks --release-type minor --default-features
     Parsing rgb v0.8.90 (current)
      Parsed [   0.909s] (current)
     Parsing rgb v0.8.45 (baseline, cached)
      Parsed [   0.164s] (baseline)
    Checking rgb v0.8.45 -> v0.8.90 (assume minor change)
     Checked [   0.014s] 69 checks; 69 passed, 6 unnecessary
    Finished [   1.103s] rgb
❯ cargo +stable semver-checks --release-type minor --all-features
     Parsing rgb v0.8.90 (current)
      Parsed [   1.416s] (current)
     Parsing rgb v0.8.45 (baseline, cached)
      Parsed [   0.160s] (baseline)
    Checking rgb v0.8.45 -> v0.8.90 (assume minor change)
     Checked [   0.025s] 69 checks; 69 passed, 6 unnecessary
    Finished [   1.623s] rgb