search

kornelski / slip

Slip.js — UI library for manipulating lists via swipe and drag gestures
BSD 2-Clause "Simplified" License
2.44k stars 213 forks source link

Fix z-index bugs in Chrome #16

Closed Pasvaz closed 10 years ago

Pasvaz commented 10 years ago

Now the regexp catches only Chrome/34, if you use [34] the regexp actually matches any number between 3 and 4, for instance Chrome/35 or Chrome/40 are matching the expression.

kornelski commented 10 years ago

The intention was to catch all current and near-future Chrome versions, so 30-40 was deliberate (although Chrome devs will hate me when they reach version 300 ;)

Have you checked that workarounds are not needed any more?

Pasvaz commented 10 years ago

I'm using Chrome 35 and it works as expected, while when damnYouChrome is set to true it flickers a lot.

By the way, slip is great! thank you for sharing it.

kornelski commented 10 years ago

Thanks!

kornelski commented 10 years ago

Sorry, I'm still seeing z-index bugs in Chrome 37, so I've reverted the change. I'm afraid that flickering is the price to pay for it :(

Pasvaz commented 10 years ago

Did you test it with the last non-dev version as well? Also, do you have any fiddle, plunk or online website where I can test this behavior? I'd like to help to fix it.

kornelski commented 10 years ago

Yes, I'm testing with Canary version (on Mac OS X). You can see the problem on http://pornel.net/slip

  1. Grab element to reorder
  2. Drag it down until it's more than half way below another element

You will see that the dragged element appears underneath the element in the list:

grab

but the element that is being dragged should always be on top of other elements.

Pasvaz commented 10 years ago

gotcha! I'll play a bit with it, let's see if something useful come up.