removed unneeded commas at end of lists

kornelski / slip

Slip.js — UI library for manipulating lists via swipe and drag gestures

BSD 2-Clause "Simplified" License

2.44k stars 213 forks source link

Closed developitz closed 9 years ago

developitz commented 9 years ago

I have removed the unneeded commas at the end of lists to make it es3 compliant in jshint.

lluchs commented 9 years ago

See #21. A minifier will remove these commas anyways and even without them the script won't work in a ES3 browser due to [].forEach.

AnBauer commented 9 years ago

But if those minor changes make it possible to use the Google Closure Compiler (as the one from #21 pointed out), why keep them?

kornelski commented 9 years ago

No, sorry. I don't support ES3-only browsers and tools. The code is in ES5.

I don't know why CC chooses to be outdated by default, but if you add --language=ECMASCRIPT5 it will work.

kornelski commented 9 years ago

@AnBauer as to why keep them:

adding new element to a list only changes one line. This makes merge conflicts less likely/problematic.
it's slightly easier to write and reorder list items,
consistency in comma placement reduces chance of forgetting them.

I think it'd be better if CC updated their defaults to make it a non-issue. I've filed a bug: https://code.google.com/p/closure-compiler/issues/detail?id=1318