search

kornelski / slip

Slip.js — UI library for manipulating lists via swipe and drag gestures
BSD 2-Clause "Simplified" License
2.44k stars 213 forks source link

Suggestion: stop propagation of events to prevent collision with other libraries #45

Closed mauron85 closed 6 years ago

mauron85 commented 9 years ago

Currently all events are propagated through the DOM tree elements.

Using other libraries is complicated, because events collide with each other. Good example is using https://github.com/mango/slideout together with current version of slip is impossible.

I've made changes to slip to stop propagation of touch/mouse events, so using slip with other libs is possible. Basically, what needs to be done is:

ev.stopPropagation();
carter-thaxton commented 8 years ago

Can you be more specific where you've added this code? Or just send a pull request?

ValYouW commented 6 years ago

@carter-thaxton I have had the same issue, created a PR https://github.com/kornelski/slip/pull/100 Thanks

carter-thaxton commented 6 years ago

Merged PR #100 .