search

kornelski / slip

Slip.js — UI library for manipulating lists via swipe and drag gestures
BSD 2-Clause "Simplified" License
2.44k stars 213 forks source link

Scroll while dragging? #53

Closed mahemoff closed 8 years ago

mahemoff commented 9 years ago

Is it possible to scroll the page while dragging an element?

kornelski commented 9 years ago

This was implemented in #12. If it's not complete, then it'd be great if you could fix it :)

mahemoff commented 9 years ago

Strange, my integration's not working here on OSX Chrome. I'll check later what may be causing it.

chriscookz commented 8 years ago

I'm also running into this on Firefox. It works great on Chrome.

carter-thaxton commented 8 years ago

I believe this was fixed by #71 and #72. Feel free to reopen if you find more issues.

mahemoff commented 8 years ago

Thanks, it's better now, but I'm still seeing an issue with scrolling to the bottom of the page, where the element can be dragged to the bottom, causing the whole page to stretch vertically.

This is visible in the live demo, which points to Slip 1.2, and I've also added it at https://github.com/mahemoff/slip pointing to the latest slip.js with same result.

carter-thaxton commented 8 years ago

You're right. I'll look into it.

carter-thaxton commented 8 years ago

@mahemoff Check out the latest commit. Should fix your issue. Note that the source now also contains the example code.

@pornel I think you'll still need to update your live demo with the latest slip.js as well as some changes I've made to example.html. Just nice for those who find this library online.

mahemoff commented 8 years ago

Thanks @carter-thaxton, I'll need to re-integrate the library, will check it soon and let you know.