search

kornelski / slip

Slip.js — UI library for manipulating lists via swipe and drag gestures
BSD 2-Clause "Simplified" License
2.44k stars 213 forks source link

Destroy Slip object #77

Closed Garito closed 7 years ago

Garito commented 8 years ago

Hi! I have a list that you can reorder if a button is pressed When that happend I create the slip object and set the slip:beforereorder and the slip:reorder events in the container and so on It works as expected

Now I need to deactivate this feature if the user clicks the button again

How can I do so? Is there a destroy mechanism or something

Thanks!

kornelski commented 8 years ago

There's a detach method. Alternatively, you could use preventDefault() on slip's events to prevent it from taking actions.

Garito commented 8 years ago

I read the attach and detach methods and I wonder why attach sets accesibility attributes and the tabindex but the detach doesn't remove them

In fact if I remove them manually, the styles are not setted anymore

Must I considere this behaviour a bug or a normal one? (I think more in the 1st one, sorry :P) In my opinion, the library will be better if no trace are left after using it, don't you think so? Must to be the developer's call to use this attributes or not after using the library

What do you think?

carter-thaxton commented 8 years ago

It's probably a bug. Want to fix it, and send a pull request?

Though I love this library, it has needed quite a few fixes to be really ready to use. Pull requests are the way to improve it... Thanks.

francoismassart commented 7 years ago

It looks like the accessibility attributes are removed by the detach method... Maybe this issue should be marked as resolved ?

See this commit: https://github.com/pornel/slip/commit/2cdb693e1c38191843ea5d8f9f0002bd574cb7d6

carter-thaxton commented 7 years ago

Agreed. Looks like we simply didn't close the issue.