search

kornia / tutorials

Repository containing the Kornia related tutorials
https://kornia.github.io/tutorials/
Apache License 2.0
45 stars 32 forks source link

initial commit with hello world #1

Closed edgarriba closed 3 years ago

review-notebook-app[bot] commented 3 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

edgarriba commented 3 years ago

@ceroytres check it out. Not finished yet, in case you want to go ahead

ceroytres commented 3 years ago

@edgarriba I created a fork based on this branch and I uploaded the ZCA notebook. I was a bit busy today so I didn't do much.

edgarriba commented 3 years ago

@ceroytres now is compiling and generating the output. Need to add instructions and CI to verify that compiles: to run:

pip install -t requirements.txt
make clean
make docs

check _build/index.html

edgarriba commented 3 years ago

open questions: should we include the data here, wouldn;t be too much memory footprint for the repo in the long run ? how do we test that notebooks codes are not deprecated

edgarriba commented 3 years ago

/cc @ducha-aiki @ducha-aiki any opinions on this ?

ducha-aiki commented 3 years ago

Unles the data is very toy == couple of kilobytes, I think we should not include data directly. Instead we should put smth like into top notebook cell:

!wget http://where-is-our-cool-data.zip
!unzip our-cool-data.zip

Codes - just run them? We can add the running into CLI: https://nbconvert.readthedocs.io/en/latest/execute_api.html

jupyter nbconvert --to notebook --execute mynotebook.ipynb

edgarriba commented 3 years ago

for example a separated repo with our data ?

edgarriba commented 3 years ago

@lferraz suggests to use Github LFS: https://git-lfs.github.com to store data or even for testing