Closed Juclique closed 3 years ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
View / edit / reply to this conversation on ReviewNB
edgarriba commented on 2021-03-08T19:47:12Z ----------------------------------------------------------------
Add a proper tite -> Morphology or something more meaningful related to the content of the tutorial.
Add this on top of the title to link to Colab
[![Open in Colab](https://colab.research.google.com/assets/colab-badge.svg)](https://colab.sandbox.google.com/github/kornia/tutorials/blob/master/source/morphology_101.ipynb)
View / edit / reply to this conversation on ReviewNB
edgarriba commented on 2021-03-08T19:47:13Z ----------------------------------------------------------------
add %%capture
to remove the output
View / edit / reply to this conversation on ReviewNB
edgarriba commented on 2021-03-08T19:47:14Z ----------------------------------------------------------------
would be more neat kornia.enhance.normalize(img, 0., 255.)
View / edit / reply to this conversation on ReviewNB
edgarriba commented on 2021-03-08T19:47:14Z ----------------------------------------------------------------
same as before, use normalize to show more kornia usage
View / edit / reply to this conversation on ReviewNB
edgarriba commented on 2021-03-08T19:47:15Z ----------------------------------------------------------------
torch.tensor([[0,1,0],[1,1,1],[0,1,0]], device=device)
are good practices
View / edit / reply to this conversation on ReviewNB
edgarriba commented on 2021-03-08T19:47:15Z ----------------------------------------------------------------
maybe it's worth adding links to the functions in docs ? (optional)
View / edit / reply to this conversation on ReviewNB
edgarriba commented on 2021-03-08T19:47:16Z ----------------------------------------------------------------
Can you try to invert the output of the output so that the background is whit and edges in black? Same with the below function
Added moprhology_101.ipynb