Fix/tutorials execution ci

kornia / tutorials

Repository containing the Kornia related tutorials

https://kornia.github.io/tutorials/

Apache License 2.0

45 stars 32 forks source link

Closed ducha-aiki closed 1 year ago

ducha-aiki commented 1 year ago

review-notebook-app[bot] commented 1 year ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

edgarriba commented 1 year ago

@ducha-aiki did something change in kornia_moons ?

ducha-aiki commented 1 year ago

@edgarriba no. And it works locally for my python 3.10 env. We discussed that in slack https://kornia.slack.com/archives/C0102FPN884/p1694997707987449

johnnv1 commented 1 year ago

we will need a new version of kornia moons with a hotfix for this move-on

review-notebook-app[bot] commented 1 year ago

View / edit / reply to this conversation on ReviewNB

johnnv1 commented on 2023-09-21T22:40:04Z ----------------------------------------------------------------

Line #30.            inliers_mask.astype(bool).reshape(-1),

we can revert it

johnnv1 commented 1 year ago

mpl still mad about the same issue 🤔