Filter multiple packages?

kornilova203 / FlameViewer

Tool for flamegraphs visualization

MIT License

80 stars 7 forks source link

Filter multiple packages? #45

Closed brtubb-patagonia closed 5 years ago

brtubb-patagonia commented 5 years ago

Is it possible to filter multiple packages at the same time? It looks like the filtering is handled in Filter.kt, using Regex behind the scenes. Looks like adding a bar ('|') between packages works, but I wanted to make sure this is the correct way to filter.

If this is correct, would a note on this in the README be accepted if I submit a PR with an example?

This is a wonderfully powerful tool. Thank you for writing this excellent piece of software!

kornilova203 commented 5 years ago

Hi @brtubb-patagonia, Thank you for nice feedback! Yes, it's a regexp except that FlameViewer escapes . and $, it also replaces * with .*. It would be nice if you could add clarification to readme!

brtubb-patagonia commented 5 years ago

Thank you @kornilova-l! I'll close this out and submit a PR.