Install icon into 'hicolor' - Githubissues

kororaproject / kp-pharlap

Package for the device and proprietary driver management in Korora

4 stars 7 forks source link

Install icon into 'hicolor' #15

Open KAMiKAZOW opened 9 years ago

KAMiKAZOW commented 9 years ago

pharlap.desktop specifies the used icon as hwbrowser. On my FedUp'ed K21 installation only the Elementary theme includes an icon with that name. OTOH several icon themes ship a hwinfo icon.

Therefore I propose:

Change the .desktop file to point to hwinfo (see my upcoming PR).
Install a fallback hwinfo icon into /usr/share/icons/hicolor/scalable/apps

csmart commented 9 years ago

Hi @KAMiKAZOW thanks for the report. We have addressed this in a testing version, do you mid testing it?

sudo yum --enablerepo=korora-testing update pharlap lens

csmart commented 9 years ago

Wait, I totally misread your report, and got it confused with korora-welcome. Thank, I'll look into this and get back to you!

csmart commented 9 years ago

How about we just create a pharlap icon, and put it in hicolor and reference it directly instead of using hwinfo?

csmart commented 9 years ago

for now the icon could just be the hwinfo icon from Numix or something

KAMiKAZOW commented 9 years ago

Using hwinfo would have the advantage to be already available in various icon themes.

csmart commented 9 years ago

True.

csmart commented 9 years ago

OK, I've pushed a package to testing repo if you want to try it out.

sudo yum --enablerepo=korora-testing update pharlap lens