Remove unused 'host', 'host_scheme' and 'login_path' from the config

korotovsky / SingleSignOnServiceProviderBundle

Single Sign On bundle for Symfony2 projects. SP part.

MIT License

33 stars 18 forks source link

Remove unused 'host', 'host_scheme' and 'login_path' from the config #8

Closed Phennim closed 7 years ago

Phennim commented 7 years ago

Doesn't look like these are used. I removed them from my project and everything keeps working fine.

korotovsky commented 7 years ago

Hi @Phennim!

It's a BC breaking change, unfortunately we can't apply it for 0.3.x branch, because users could rely in these parameters as a container parameters.

korotovsky commented 7 years ago

If you want, please make this PR to 0.4.x and also please adjust the README.md

Phennim commented 7 years ago

Ah, Ok. What other changes to README.md? I removed the config references already, and can't see any other