korpling / ANNIS

ANNIS is an open source, versatile web browser-based search and visualization architecture for complex multilevel linguistic corpora with diverse types of annotation.
http://corpus-tools.org/annis/
Apache License 2.0
69 stars 25 forks source link

Can't set numbers=false and metakeys simultaneously in Grid exporter #392

Closed amir-zeldes closed 9 years ago

amir-zeldes commented 9 years ago

With the grid exporter, it's possible to set metakey parameters or numbers=false. Both should be usable at the same time using a semicolon separator:

numbers=false;metakeys=x,y,z

Currently both options work separately, but not at the same time using the ';' separator.

thomaskrause commented 9 years ago

The documentation here is unfortunately not complete: you have to use "&" as a separator and not ";". This is inconsistent with the resolver but historically grown since these parameters used to be part of a URL. We should definitely enhance the documentation and also evaluate if we want to use ";" as separator in the next release.

amir-zeldes commented 9 years ago

OK, if it’s been & for a while I think we should keep supporting it for backwards compatibility, but it wouldn’t hurt to add support for ; too for consistency. The user guide specifies semi-colon and this way we wouldn’t have to change it – just split by /;|&/

Does that sound OK?

From: Thomas Krause [mailto:notifications@github.com] Sent: Tuesday, March 17, 2015 09:06 To: korpling/ANNIS Cc: Amir Zeldes Subject: Re: [ANNIS] Can't set numbers=false and metakeys simultaneously in Grid exporter (#392)

The documentation here is unfortunately not complete: you have to use "&" as a separator and not ";". This is inconsistent with the resolver but historically grown since these parameters used to be part of a URL. We should definitely enhance the documentation and also evaluate if we want to use ";" as separator in the next release.

— Reply to this email directly or view it on GitHub https://github.com/korpling/ANNIS/issues/392#issuecomment-82334814 . https://github.com/notifications/beacon/ACFlWzm3Thpemyty3JvPoWqz31W5eLq5ks5n2B47gaJpZM4DvXA0.gif