korpling / ANNIS

ANNIS is an open source, versatile web browser-based search and visualization architecture for complex multilevel linguistic corpora with diverse types of annotation.

http://corpus-tools.org/annis/

Apache License 2.0

68 stars 25 forks source link

Address issues in #782 #783

Closed thomaskrause closed 2 years ago

thomaskrause commented 2 years ago

782 reports two issues found by automatic code analysis which also have been found by Sonarcloud before.

The fix for one of the potential problems is not to include any information from the exception at all, even if only the message (and not as claimed the whole stacktrace) is exposed.

The second issue is not an issue after reviewing this again. But the explanation in the comment why this is needed/ok was wrong. I updated the comment for future reviewers to explain more what is going on and why this code is safe.

thomaskrause commented 2 years ago

bors r+

bors[bot] commented 2 years ago

Build failed:

Execute all automated tests on JDK 11

thomaskrause commented 2 years ago

bors r+

bors[bot] commented 2 years ago

Merge conflict.

thomaskrause commented 2 years ago

bors r+

bors[bot] commented 2 years ago

Canceled.

thomaskrause commented 2 years ago

bors r+

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication

bors[bot] commented 2 years ago

Build succeeded: