korsbo / Latexify.jl

Convert julia objects to LaTeX equations, arrays or other environments.
MIT License
544 stars 55 forks source link

move from Requires to extensions on 1.9 #250

Closed KristofferC closed 1 year ago

KristofferC commented 1 year ago

I didn't run the tests because SymEngine fails to build on an mac M1.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 38.09% and project coverage change: -0.31 :warning:

Comparison is base (12c0408) 72.23% compared to head (b6abb90) 71.92%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #250 +/- ## ========================================== - Coverage 72.23% 71.92% -0.31% ========================================== Files 23 23 Lines 940 944 +4 ========================================== Hits 679 679 - Misses 261 265 +4 ``` | [Impacted Files](https://codecov.io/gh/korsbo/Latexify.jl/pull/250?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Niklas+Korsbo) | Coverage Δ | | |---|---|---| | [ext/LatexifyDiffEqBaseExt.jl](https://codecov.io/gh/korsbo/Latexify.jl/pull/250?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Niklas+Korsbo#diff-ZXh0L0xhdGV4aWZ5RGlmZkVxQmFzZUV4dC5qbA==) | `0.00% <0.00%> (ø)` | | | [ext/LatexifyDiffEqBiologicalExt.jl](https://codecov.io/gh/korsbo/Latexify.jl/pull/250?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Niklas+Korsbo#diff-ZXh0L0xhdGV4aWZ5RGlmZkVxQmlvbG9naWNhbEV4dC5qbA==) | `0.00% <0.00%> (ø)` | | | [src/Latexify.jl](https://codecov.io/gh/korsbo/Latexify.jl/pull/250?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Niklas+Korsbo#diff-c3JjL0xhdGV4aWZ5Lmps) | `35.29% <0.00%> (-10.86%)` | :arrow_down: | | [ext/LatexifySymEngineExt.jl](https://codecov.io/gh/korsbo/Latexify.jl/pull/250?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Niklas+Korsbo#diff-ZXh0L0xhdGV4aWZ5U3ltRW5naW5lRXh0Lmps) | `80.00% <66.66%> (ø)` | | | [ext/LatexifyDataFramesExt.jl](https://codecov.io/gh/korsbo/Latexify.jl/pull/250?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Niklas+Korsbo#diff-ZXh0L0xhdGV4aWZ5RGF0YUZyYW1lc0V4dC5qbA==) | `93.33% <93.33%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Niklas+Korsbo). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Niklas+Korsbo)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

KristofferC commented 1 year ago

Tests seem to run with very old versions of packages.

(jl_QaRzuP) pkg> st -m --outdated
Status `/private/var/folders/tp/2p4x9ygx48sgsdl1ccg1mp_40000gn/T/jl_QaRzuP/Manifest.toml`
⌃ [79e6a3ab] Adapt v3.6.0 (<v3.6.1)
⌅ [4fba245c] ArrayInterface v2.14.17 (<v7.2.1): DiffEqBase, DiffEqJump, LabelledArrays, RecursiveArrayTools
⌅ [324d7699] CategoricalArrays v0.7.7 (<v0.10.7): DataFrames
⌅ [d360d2e6] ChainRulesCore v0.9.45 (<v1.15.7): DiffEqBase
⌅ [34da2185] Compat v3.46.1 (<v4.6.1): CategoricalArrays, ChainRulesCore, DataFrames, DiffEqBiological, DiffEqJump, SymEngine
⌃ [187b0558] ConstructionBase v1.4.1 (<v1.5.1)
⌃ [a93c6f00] DataFrames v0.20.0 (<v1.5.0)
⌅ [864edb3b] DataStructures v0.17.20 (<v0.18.13): DiffEqBiological
⌃ [2b5f629d] DiffEqBase v6.44.3 (<v6.122.1)
⌃ [eb300fae] DiffEqBiological v3.11.0 (<v4.3.0)
⌅ [c894b116] DiffEqJump v6.10.0 (<v8.6.3): DiffEqBiological
⌅ [ffbed154] DocStringExtensions v0.8.6 (<v0.9.3): DiffEqBase
⌅ [497a8b3b] DoubleFloats v0.9.1 (<v1.2.3): HomotopyContinuation
⌅ [7c1d4256] DynamicPolynomials v0.3.21 (<v0.4.6): DiffEqBiological, HomotopyContinuation
⌅ [c145ed77] GenericSchur v0.4.1 (<v0.5.3): DoubleFloats
⌅ [f213a82b] HomotopyContinuation v1.2.1 (<v2.8.0): DiffEqBiological
⌅ [42fd0dbc] IterativeSolvers v0.8.5 (<v0.9.2): DiffEqBase
⌃ [2ee39098] LabelledArrays v1.6.6 (<v1.14.0)
⌅ [e6f89c97] LoggingExtras v0.4.9 (<v1.0.0): DiffEqBase
⌅ [e1d29d7a] Missings v0.4.5 (<v1.1.0): CategoricalArrays, DataFrames
⌅ [291d046c] MixedSubdivisions v0.3.4 (<v1.1.2): HomotopyContinuation
⌅ [102ac46a] MultivariatePolynomials v0.3.18 (<v0.4.7): DynamicPolynomials, FixedPolynomials, HomotopyContinuation, MixedSubdivisions
⌅ [d8a4904e] MutableArithmetics v0.2.22 (<v1.2.3): DynamicPolynomials, MultivariatePolynomials
⌅ [f27b6e38] Polynomials v0.8.0 (<v3.2.7): DoubleFloats
⌅ [2dfb63ee] PooledArrays v0.5.3 (<v1.4.2): DataFrames
⌅ [08abe8d2] PrettyTables v0.6.0 (<v2.2.2): HomotopyContinuation
⌃ [be4d8f0f] Quadmath v0.5.6 (<v0.5.8)
⌅ [3cdcf5f2] RecipesBase v0.7.0 (<v1.3.3): DiffEqBiological, SymEngine
⌃ [731186ca] RecursiveArrayTools v2.7.2 (<v2.38.0)
⌅ [f2c3362d] RecursiveFactorization v0.1.0 (<v0.2.18): DiffEqBase
⌅ [189a3867] Reexport v0.2.0 (<v1.2.2): CategoricalArrays, DataFrames, DiffEqBiological, PrettyTables
⌅ [f2b01f46] Roots v1.4.1 (<v2.0.10): DiffEqBase
⌅ [efcf1570] Setfield v0.8.2 (<v1.1.1): Roots
⌅ [a2af1166] SortingAlgorithms v0.3.2 (<v1.1.0): DataFrames
⌅ [276daf66] SpecialFunctions v0.10.3 (<v2.2.0): DoubleFloats, SymEngine
⌅ [90137ffa] StaticArrays v0.11.1 (<v1.5.17): DiffEqBase, DiffEqJump, HomotopyContinuation, MixedSubdivisions, RecursiveArrayTools
⌅ [123dc426] SymEngine v0.7.1 (<v0.8.7): DiffEqBiological
⌅ [bd369af6] Tables v0.2.11 (<v1.10.0): DataFrames, PrettyTables
ChrisRackauckas commented 1 year ago

tests are using DiffEqBiological but should be using Catalyst.

chriselrod commented 1 year ago

@korsbo ?

vtjnash commented 1 year ago

bump?

vtjnash commented 1 year ago

Replaces https://github.com/korsbo/Latexify.jl/pull/245?

KristofferC commented 1 year ago

Hadn't seen that heh

gustaphe commented 1 year ago

Sorry about the delay in replies here. I'd be comfortable merging either of this or #245, but I don't know if there is any difference apart from a couple of style choices. Can any of you spot anything?

gustaphe commented 1 year ago

Closed with #245