korsbo / Latexify.jl

Convert julia objects to LaTeX equations, arrays or other environments.
MIT License
562 stars 59 forks source link

Convert extensions to recipes #263

Closed gustaphe closed 3 months ago

gustaphe commented 1 year ago

I've wanted to do this for a while, and it recently became much easier. Low priority, but maybe at least worth keeping in mind if we ever need to change either extension.

If this breaks something, that something was not in the tests.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 75.00% and project coverage change: -0.26 :warning:

Comparison is base (1dcae2c) 82.38% compared to head (78290b1) 82.12%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #263 +/- ## ========================================== - Coverage 82.38% 82.12% -0.26% ========================================== Files 21 21 Lines 829 817 -12 ========================================== - Hits 683 671 -12 Misses 146 146 ``` | [Impacted Files](https://codecov.io/gh/korsbo/Latexify.jl/pull/263?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Niklas+Korsbo) | Coverage Δ | | |---|---|---| | [ext/SymEngineExt.jl](https://codecov.io/gh/korsbo/Latexify.jl/pull/263?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Niklas+Korsbo#diff-ZXh0L1N5bUVuZ2luZUV4dC5qbA==) | `50.00% <50.00%> (-30.00%)` | :arrow_down: | | [ext/DataFramesExt.jl](https://codecov.io/gh/korsbo/Latexify.jl/pull/263?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Niklas+Korsbo#diff-ZXh0L0RhdGFGcmFtZXNFeHQuamw=) | `83.33% <83.33%> (-10.00%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

rodrigomha commented 2 months ago

@gustaphe A quick question here. What is now the intended form to use create a markdown table from a Dataframe now that mdtable(DataFrame) is not supported directly? This broke some of my documentation and required to fix Latexify in 0.16.3 for now.

Thanks

gustaphe commented 2 months ago

That is unfortunate, we should have had a test for that. I'm not currently at my computer, but latexify(df) or latexify(df; env=:mdtable) should do the same thing.