search

korsbo / Latexify.jl

Convert julia objects to LaTeX equations, arrays or other environments.
MIT License
544 stars 55 forks source link

Fix potential bugs by switching from Formatting.jl to Format.jl #281

Closed ScottPJones closed 4 months ago

ScottPJones commented 4 months ago

Also eliminated the need to do @eval at run-time just for numeric formatting, which also eliminates the need for Printf as a dependency.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (6b869c3) 82.38% compared to head (cf8b97f) 82.66%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #281 +/- ## ========================================== + Coverage 82.38% 82.66% +0.27% ========================================== Files 21 21 Lines 829 819 -10 ========================================== - Hits 683 677 -6 + Misses 146 142 -4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ScottPJones commented 4 months ago

Note: the failure on nightly happens on master, and is unrelated to this PR, and the Documentation check is also unrelated to the change.

Can this be merged now? Thanks in advance!

nhz2 commented 4 months ago

This looks good to me.

oscardssmith commented 4 months ago

Can this be merged?

ScottPJones commented 4 months ago

Can this be merged?

Just waiting on someone who has permission to do so!