Polynomial Regression Predictor

kortirso / elixir_learn_kit

Elixir library for machine learning

32 stars 4 forks source link

Closed davidrichey closed 5 years ago

davidrichey commented 5 years ago

Note: dependency Matrix added for Matrix math

kortirso commented 5 years ago

@davidrichey Thank you for PR, but 1 have a few questions

what is better practice: left private functions in core module or hide them in additional?
you declared @types, but there are no specs
is it possible to add calculation of the coefficient of determination R^2 of the prediction?
and there are a few comments in the code

davidrichey commented 5 years ago

@kortirso thank you for the detailed comments and questions. I have update this PR with a couple commits:

First Formatter Updates of Files I intend to change
Next the Updates from your comments - I have pulled some on the calculations out of the Linear.Calculations as it will be applied to the Polynomial regression error calculation
And last, added polynomial regression scoring

kortirso commented 5 years ago

@davidrichey Merged, thank you for your work