search

korymath / talk-generator

talk-generator is capable of generating coherent slide decks based on a single topic suggestion.
MIT License
124 stars 9 forks source link

Unused files? #44

Closed twinters closed 5 years ago

twinters commented 5 years ago

There are quite some files that are currently completely not covered by any test case, and not used anywhere in the project. I was wondering if we still need the following files, or if we can delete them, or if we need them if they should be in different repositories:

What's your opinion about these files, @korymath @h0h0h0 ? Should any of them stay? (I presume the aws_s3.py is probably the only one being used by something externally?)

korymath commented 5 years ago

I am a staunch supporter of cleaning up. Stress.py was about timing tests for the paper.

I’m good with all of these getting dusted.

twinters commented 5 years ago

Alright, removed parallel_util.py, random_word_util.py and stress.py. I'll wait for @h0h0h0's approval before touching the two server related files/folders.

h0h0h0 commented 5 years ago

Leave aws_s3 and the server files for now. I will handle those under #35 - i think you are good for now!

P.S. - double check that ranom_word_util is not being used . i thought i had it used somewhere.

h0h0h0 commented 5 years ago

Following up: random_word_util was only being used by the flask portion of the talk-generator in case some word was not selected. So that can stay killed.

Incoming pull request will remove aws_s3 and server files.

korymath commented 5 years ago

Sounds great! Nice one.

On Wed, Aug 14, 2019 at 8:37 AM Shaun Farrugia notifications@github.com wrote:

Following up: random_word_util was only being used by the flask portion of the talk-generator in case some word was not selected. So that can stay killed.

Incoming pull request will remove aws_s3 and server files.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/korymath/talk-generator/issues/44?email_source=notifications&email_token=AABLPM7BNTFH3P2F3J7YWRDQEQKEJA5CNFSM4IIK2QD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4JAA2Q#issuecomment-521273450, or mute the thread https://github.com/notifications/unsubscribe-auth/AABLPM63NOO6RS7KAEKY753QEQKEJANCNFSM4IIK2QDQ .

--

Kory Mathewson https://korymathewson.com